src/util/StringUtils.ts (1)

119-127: Minor hardening: coerce to an integer and clamp explicitly; clarify non-crypto intent.

Avoid surprises with floats/Infinity and document that SHA-1 here is non-security-critical.

Apply:

 export function hash(input: string, options: IHashOptions = {}): string {
   const hashFunction = shajs("sha1")
   hashFunction.update(input, "utf8")
   const hashedInput = hashFunction.digest("hex")
-  if (options.length && options.length > 0) {
-      return hashedInput.slice(0, options.length)
-  }
+  const len = Number.isFinite(options.length as number)
+    ? Math.trunc(options.length as number)
+    : 0
+  if (len > 0) {
+    // slice already caps to hashedInput.length; the Math.min keeps intent explicit
+    return hashedInput.slice(0, Math.min(len, hashedInput.length))
+  }
   return hashedInput
 }

Optional JSDoc tweak:

/**
 * Returns a SHA-1 hex digest for internal IDs/aliases (not for cryptographic security).
 */

test/unit/util/string-utils.ts (1)

123-190: Good coverage; consider deduping the two “length > digest size” cases.

Both tests at Lines 177–182 and 184–189 assert the same behavior. Keep one to reduce redundancy.

Apply:

@@
-        it("should clamp length larger than hash length to full length", () => {
-            const full = "aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d"
-            const result = hash("hello", { length: 999 })
-            expect(result).to.be.equal(full)
-            expect(result).to.have.lengthOf(40)
-        })
-
         it("should return full length when options.length exceeds digest size", () => {
             const full = hash("hello")
-            const over = hash("hello", { length: 100 })
+            const over = hash("hello", { length: 999 })
             expect(over).to.equal(full)
             expect(over).to.have.lengthOf(40)
         })

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

src/util/StringUtils.ts (2)

113-118: Doc: clarify truncation semantics.

Consider noting explicitly that when options.length is <= 0 or not provided, the function returns the full 40-char digest. This avoids ambiguity for callers reading the JSDoc.

 /**
- * Returns a SHA-1 hex digest for internal IDs/aliases (not for cryptographic security)
+ * Returns a SHA-1 hex digest for internal IDs/aliases (not for cryptographic security).
+ * Note: if `options.length` is not provided or <= 0, the full 40-character digest is returned.
  *
  * @param input String to be hashed.
  * @param options.length Optionally, shorten the output to desired length.
  */

---

109-111: Export the options type for cleaner public typings.

hash is exported; consumers will see its signature in .d.ts. Exporting IHashOptions improves DX and avoids anonymous inlined types in declarations.

-interface IHashOptions {
+export interface IHashOptions {
   length?: number
 }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro