-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: Fix reload option typo
#11601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix reload option typo
#11601
Conversation
WalkthroughDocumentation grammar corrections in one docs page and one TypeScript JSDoc comment. No functional, behavioral, API, or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/repository/SaveOptions.ts (1)
35-35: Optional wording polish for clarity and precision.Consider using "that" and referring to RETURNING/OUTPUT as a clause for accuracy.
- * It will work only on databases which do not support RETURNING / OUTPUT statement. + * This option has effect only on databases that do not support the RETURNING / OUTPUT clause.docs/docs/working-with-entity-manager/6-repository-api.md (1)
458-458: Optional phrasing improvement to mirror SQL terminology.Using "clause" is more precise than "statement" here.
- - `reload`: boolean - Flag to determine whether the entity that is being persisted should be reloaded during the persistence operation. It will work only on databases which do not support RETURNING / OUTPUT statement. Enabled by default. + - `reload`: boolean - Flag to determine whether the entity that is being persisted should be reloaded during the persistence operation. This option has effect only on databases that do not support the RETURNING / OUTPUT clause. Enabled by default.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/docs/working-with-entity-manager/6-repository-api.md(1 hunks)src/repository/SaveOptions.ts(1 hunks)
🔇 Additional comments (2)
src/repository/SaveOptions.ts (1)
35-35: LGTM — corrected subject–verb agreement.The JSDoc fix is correct and aligns with the docs update.
docs/docs/working-with-entity-manager/6-repository-api.md (1)
458-458: LGTM — grammar fix is consistent with code comments.The updated phrasing matches the SaveOptions.ts JSDoc and reads correctly.
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help @radovanovic-stevan
Kudos for your first PR in this project 🎉👏
commit: |
Description of change
Just a small typo I've noticed while using TypeORM recently. Fixed it in two places.
Pull-Request Checklist
masterbranchFixes #00000Summary by CodeRabbit