Reviewing files that changed from the base of the PR and between 17cf837 and 3c34e01.

• src/decorator/options/VirtualColumnOptions.ts (1 hunks)
• src/query-builder/SelectQueryBuilder.ts (1 hunks)
• test/functional/columns/virtual-columns/entity/Company.ts (2 hunks)
• test/functional/columns/virtual-columns/entity/Employee.ts (1 hunks)
• test/functional/columns/virtual-columns/entity/TimeSheet.ts (2 hunks)
• test/functional/columns/virtual-columns/virtual-columns.ts (6 hunks)

src/decorator/options/VirtualColumnOptions.ts (1)

13-17: Default value needs to be enforced in implementation

The comment says the new select flag “Default value is true”, but the interface alone does not apply a default—undefined will propagate unless some runtime path converts it to true.
Double-check that:

1. VirtualColumn registration code explicitly sets select = true when the option is undefined, mirroring the behaviour of regular columns.
2. All places that consume metadata.select treat undefined the same as true.

Otherwise virtual columns could silently become non-selectable.

src/query-builder/SelectQueryBuilder.ts (1)

2968-2977: LGTM! Clean simplification that supports virtual column selection.

The method correctly filters selects to find all matches for either the alias name directly or any of the alias's column property paths. This simplified approach removes conditional branching while maintaining the same functionality and properly supports the new virtual column selection semantics introduced in this PR.

test/functional/columns/virtual-columns/entity/Employee.ts (2)

7-8: LGTM! Clean simplification of the decorator.

Removing explicit type and length options from @PrimaryColumn() improves readability while TypeORM correctly infers the column type from the TypeScript property type.

---

13-16: Appropriate use of cascading for test entities.

Adding cascade: true simplifies test data creation by allowing nested entity persistence. This is a good pattern for test fixtures.

Note: While cascading is convenient here, use it cautiously in production entities as it can lead to unintended data modifications or deletions.

test/functional/columns/virtual-columns/entity/TimeSheet.ts (3)

1-1: Good use of dedent for SQL template literals.

Aliasing dedent as sql clearly indicates SQL query strings and improves readability for multi-line queries.

---

17-23: Correct relationship direction and consistent cascading pattern.

The change from ManyToOne to OneToMany for activities better represents the domain model where a timesheet contains multiple activities. The cascade option aligns with the test data creation pattern used across other entities.

---

25-29: Well-structured virtual column with appropriate nullable type.

The virtual column correctly:

• Uses the sql template for better readability
• Marks the return type as optional since SUM() returns null when no activities exist
• Properly aggregates hours from related activities

test/functional/columns/virtual-columns/virtual-columns.ts (4)

2-2: Comprehensive setup for testing complex virtual columns.

The addition properly:

• Imports dedent for SQL readability
• Sets up MySQL-specific query syntax with backticks
• Tests complex multi-table aggregation queries
• Aligns with the totalReportedHours virtual column implementation

Also applies to: 42-54

---

157-177: Excellent use of cascading relations for test data setup.

The nested object creation pattern:

• Significantly simplifies test data setup
• Makes the entity relationships clear
• Properly leverages the cascade options added to the entities
• Reduces test boilerplate

---

89-89: Skip minor assertion style changes.

Also applies to: 147-147

---

302-355: Thorough test coverage for the new non-selectable virtual column feature.

This test effectively validates:

• Virtual columns with select: false are excluded by default
• Explicit selection via addSelect() works correctly
• Complex aggregation queries return expected results

The test directly verifies the PR's main objective of allowing virtual columns to be initially non-selectable.

test/functional/columns/virtual-columns/entity/Company.ts (4)

1-1: Consistent patterns with other entity files.

Good use of:

• sql template literal for query readability
• Simplified @PrimaryColumn() decorator

Also applies to: 12-13

---

15-18: Consistent cascading pattern for test relations.

The cascade: true option on the employees relation aligns with the test data creation pattern used throughout these test entities.

---

20-24: Improved virtual column definition.

The updates properly:

• Use sql template for better query formatting
• Mark the type as optional to handle aggregate results correctly

---

26-35: Excellent implementation of the non-selectable virtual column feature.

This virtual column perfectly demonstrates the PR's objective:

• select: false ensures it's not included in queries by default
• Complex multi-table aggregation showcases real-world usage
• Proper use of sql template for the multi-line query
• Correct optional typing for aggregate results

This is the centerpiece implementation that enables virtual columns to be initially non-selectable, addressing issue #11277.

• Create PR with unit tests
• Post copyable unit tests in a comment