Fix release issues #11303
Merged
Fix release issues #11303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Adding parameters to the rimraf call should be done in other places (tests) too, there were some PRs doing that 🙂 |
Member
Author
|
Ah OK I didn't know that. Good point though - rimraf is just a dev dependency so won't affect node compatibility for end users. Or are we aiming to support node 18 also for library development? |
Collaborator
|
@michaelbromley we run the tests on node 18 in the pipelines (github actions). They use rimraf quite a lot, so if they didn't fail, probably it's still okay at the moment 🤷🏼♂️ while node 18 is no longer supported, it can happen that they didn't explicitly switch to node 20 APIs yet. |
aberonni
pushed a commit
to global-121/typeorm
that referenced
this pull request
Mar 5, 2025
ThbltLmr
pushed a commit
to ThbltLmr/typeorm
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues I encountered when following Umed's instructions to create a new TypeORM release.