Skip to content

fix(npm-readme): resolve missing image file pt. 2 #11291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelbromley merged 2 commits into from
Feb 14, 2025
Merged

fix(npm-readme): resolve missing image file pt. 2 #11291

michaelbromley merged 2 commits into from
Feb 14, 2025

Conversation

@naorpeled
Copy link
Member

@naorpeled naorpeled commented Feb 14, 2025 •
edited
Loading

Description of change

pt 2 of this fix

image

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@coveralls
Copy link

coveralls commented Feb 14, 2025 •
edited
Loading

Coverage Status

coverage: 72.372% (-0.002%) from 72.374%
when pulling b64d713 on fix/npm-readme/resolve-missing-image-pt-2
into c554f58 on master.

@michaelbromley michaelbromley merged commit 981cf82 into master Feb 14, 2025
85 of 96 checks passed
@naorpeled naorpeled deleted the fix/npm-readme/resolve-missing-image-pt-2 branch February 14, 2025 20:01
aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
@naorpeled
fix(npm-readme): resolve missing image file pt. 2 (typeorm#11291)
1649652
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@naorpeled @ThbltLmr
fix(npm-readme): resolve missing image file pt. 2 (typeorm#11291)
0cc73ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbromley michaelbromley michaelbromley approved these changes

@OSA413 OSA413 OSA413 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naorpeled @coveralls @michaelbromley @OSA413