Skip to content

Conversation

@alper
Copy link

@alper alper commented Feb 13, 2025

Description of change

I did some work in another PR and it wasn't entirely clear to me how to setup tests quickly. So after being asked I gave the documentation a pass to clarify some things and generally copy edit it.

Asked here in Discord: https://discord.com/channels/1124626013360488529/1338927560397946983/1339634447557070889

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@alper alper force-pushed the push-qlrnqzkrvqrq branch 3 times, most recently from 5d24f1b to 9a7d1a4 Compare February 13, 2025 19:01
Copy link
Collaborator

@mguida22 mguida22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left some small suggestions but this is very helpful.

Co-authored-by: Mike Guida <mike@mguida.com>
@alper alper force-pushed the push-qlrnqzkrvqrq branch from 7d91953 to cbd7178 Compare February 13, 2025 21:50
@michaelbromley michaelbromley merged commit e3056d1 into typeorm:master Feb 14, 2025
32 of 34 checks passed
@coveralls
Copy link

Coverage Status

coverage: 72.374% (+0.002%) from 72.372%
when pulling cbd7178 on alper:push-qlrnqzkrvqrq
into b9263d5 on typeorm:master.

aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants