Skip to content

docs: fix missing DataSource in migrations config #11249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelbromley merged 1 commit into from
Feb 14, 2025
Merged

docs: fix missing DataSource in migrations config #11249

michaelbromley merged 1 commit into from
Feb 14, 2025

Conversation

@maciej-ka
Copy link
Contributor

@maciej-ka maciej-ka commented Jan 17, 2025 •
edited
Loading

Motivation

Running migrations using current documentation ends with error:
Error: Given data source file must contain export of a DataSource instance

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change N/A
  • This pull request links relevant issues as Fixes #0000 N/A
  • There are new or updated unit tests validating the change N/A
  • Documentation has been updated to reflect this change N/A
  • The new commits follow conventions explained in CONTRIBUTING.md N/A

gioboa
gioboa approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maciej-ka nice catch 👏

@gioboa gioboa added documentation size-xs Trivial tasks or quick fixes. Estimated effort: Less than 1 hour labels Jan 21, 2025
@coveralls
Copy link

coveralls commented Jan 25, 2025

Coverage Status

coverage: 72.343% (-0.02%) from 72.359%
when pulling 80fb869 on maciej-ka:docs-fix-migration-config
into 9d1d3f1 on typeorm:master.

@michaelbromley michaelbromley merged commit 87b9fad into typeorm:master Feb 14, 2025
56 checks passed
@maciej-ka maciej-ka deleted the docs-fix-migration-config branch February 15, 2025 05:58
aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
@maciej-ka
docs: fix missing DataSource in migrations config (typeorm#11249)
2d1feb9
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@maciej-ka @ThbltLmr
docs: fix missing DataSource in migrations config (typeorm#11249)
27da5c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naorpeled naorpeled naorpeled approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

documentation size-xs Trivial tasks or quick fixes. Estimated effort: Less than 1 hour

Projects

TypeORM Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maciej-ka @coveralls @naorpeled @gioboa @michaelbromley