Update relations.md #11161
Merged
Update relations.md #11161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default values of the options are updated, and the possible values of orphanedRowAction are placed in the diagram for better reading.
jorenvandeweyer
suggested changes
Dec 23, 2024
Contributor
|
@madmaxdios can you apply the feedback please? |
Contributor
Author
|
@jorenvandeweyer srry for delay, is there anything else I need to do now? |
jorenvandeweyer
approved these changes
Jan 16, 2025
gioboa
requested changes
Jan 19, 2025
Collaborator
gioboa
left a comment
There was a problem hiding this comment.
it looks great to me 🎉
My only concern is about the default syntax
In this way is more understandable
`eager: boolean` (default: `false`)
We are more than happy to merge this PR if you fix this small thing.
Thanks for your help @madmaxdios
Contributor
Author
|
I think now is ok |
gioboa
requested changes
Jan 22, 2025
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
gioboa
approved these changes
Jan 24, 2025
Collaborator
gioboa
left a comment
There was a problem hiding this comment.
Thanks @madmaxdios well done ✅
Contributor
Author
|
Thanks you @gioboa for all your work. |
aberonni
pushed a commit
to global-121/typeorm
that referenced
this pull request
Mar 5, 2025
ThbltLmr
pushed a commit
to ThbltLmr/typeorm
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default values of the options are updated, and the possible values of orphanedRowAction are placed in the diagram for better reading.