Add support for better-sqlite3 v10 and 11 #11096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenvandeweyer
approved these changes
Dec 30, 2024
Contributor
jorenvandeweyer
left a comment
There was a problem hiding this comment.
should these version be added to the test matrix?
…-versions # Conflicts: # package-lock.json # package.json
mguida22
reviewed
Jan 3, 2025
Collaborator
mguida22
left a comment
There was a problem hiding this comment.
Have you been able to test TypeORM with better-sqlite3 versions 10 and 11?
Member
|
Can anyone confirm this has been tested with the newer version of better-sqlite3 being added? If so we can merge. Also - what's the reason for removing the v7 support? |
Contributor
Author
|
Tests ran fine locally when I tried to run them, so that should be ok. |
Member
|
OK I found it, v7 support was removed because it does not support node v20 #11183 |
michaelbromley
approved these changes
Jan 21, 2025
aberonni
pushed a commit
to global-121/typeorm
that referenced
this pull request
Mar 5, 2025
7 tasks
ThbltLmr
pushed a commit
to ThbltLmr/typeorm
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
better-sqlite3 has had versions 10 and 11 available for some time now. It would be useful for this repo to support the new versions in addition to the older ones.
This PR would fix issues such as #10894
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000