Skip to content

Conversation

@ngxquang
Copy link
Contributor

@ngxquang ngxquang commented Sep 18, 2024

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md


### 4.1. Lazy loading

- Lazy loading loads the relation data only when needed, reducing database load when all related data isn't always necessary.
Copy link
Collaborator

@gioboa gioboa Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngxquang for your help.
I think is good to have links to the specific doc pages (in this case https://typeorm.io/eager-and-lazy-relations#lazy-relations) to have a whole description on the topic.
This suggestion is for all the tips you added. Nice job 💪
Kudos for your first PR in this project 🥳

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I've updated the documentation to include the lazy and eager relations links. Let me know if there's anything else you'd like adjusted!

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice piece of documentation, really clear and straight to the point.
Thanks @ngxquang for your help
I added this PR in our release board

@gioboa gioboa added the size-xs Trivial tasks or quick fixes. Estimated effort: Less than 1 hour label Jan 24, 2025
@michaelbromley michaelbromley merged commit 5f60392 into typeorm:master Feb 14, 2025
60 of 61 checks passed
aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation size-xs Trivial tasks or quick fixes. Estimated effort: Less than 1 hour

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants