-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: add performance and optimizing #11068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| ### 4.1. Lazy loading | ||
|
|
||
| - Lazy loading loads the relation data only when needed, reducing database load when all related data isn't always necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ngxquang for your help.
I think is good to have links to the specific doc pages (in this case https://typeorm.io/eager-and-lazy-relations#lazy-relations) to have a whole description on the topic.
This suggestion is for all the tips you added. Nice job 💪
Kudos for your first PR in this project 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've updated the documentation to include the lazy and eager relations links. Let me know if there's anything else you'd like adjusted!
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice piece of documentation, really clear and straight to the point.
Thanks @ngxquang for your help
I added this PR in our release board
Description of change
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000