re-run circleci test?

Hi,

This PR would be very useful for those of us working with SQL Server in high availability setups.
In our production environment we also rely on HA databases, and the MultiSubnetFailover option is important to keep connections stable during failovers.

Since many large-scale applications use this type of database configuration, having support for this parameter in TypeORM would be a solid improvement.

Is there anything blocking this from being merged ?

Thanks a lot for the review and clarification 👍
Since the change is quite small (just passing the parameter and updating the docs), would it make sense to resolve the conflicts and tag another maintainer for review? That way we could hopefully get this merged soon.

Hi @sgarner , @michaelbromley,

This PR has been open since March 2024 and already has one approval.
The change is quite small (adding support for the MultiSubnetFailover parameter in SQL Server connections, plus a docs update), but it’s important for working with HA databases.

Would you mind taking a quick look so we can hopefully get this merged ?

Walkthrough

Adds a new optional Sql Server connection option multiSubnetFailover?: boolean to the TypeScript interface and documents it in the SQL Server driver docs. No control flow or runtime logic changes are included in this diff.

Changes

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor App as Application
    participant Driver as SQL Server Driver
    participant DNS as DNS
    participant IPs as Target IPs

    App->>Driver: createConnection({ multiSubnetFailover })
    Driver->>DNS: Resolve hostname -> IP list
    DNS-->>Driver: [IP1, IP2, ...]
    
    alt multiSubnetFailover = false
        note right of Driver: Default behavior
        Driver->>IPs: Attempt connect to first IP, fallback sequentially
        IPs-->>Driver: First successful connection
    else multiSubnetFailover = true
        rect rgba(200, 230, 255, 0.3)
        note right of Driver: Parallel connection attempts
        Driver->>IPs: Connect to all resolved IPs in parallel
        IPs-->>Driver: First successful connection wins
        end
        Driver--x IPs: Cancel remaining attempts
    end

    Driver-->>App: Connected SqlServer client

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A hop, a skip, across subnets I go,
Parallel burrows where IP rivers flow.
Flip one flag—I’m swift as spring clover,
First tunnel wins, the search is over.
Thump-thump! says the driver, eager and able—
Multi-subnet dreams on my connection table. 🐇✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@10804

commit: 2e0ab1a

coverage: 76.427%. remained the same
when pulling 2e0ab1a on isaru66:master
into d4f7b44 on typeorm:master.