Skip to content

Update select-query-builder.md #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelbromley merged 1 commit into from
Jan 20, 2025
Merged

Update select-query-builder.md #10763

michaelbromley merged 1 commit into from
Jan 20, 2025

Conversation

@peruzzoarthur
Copy link
Contributor

@peruzzoarthur peruzzoarthur commented Mar 11, 2024

Crystal Maiden, not Cristal.

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@peruzzoarthur
Update select-query-builder.md
065b542 
Crystal Maiden, not Cristal.
@michaelbromley
Copy link
Member

michaelbromley commented Jan 5, 2025

Am I missing some reference here that makes "Cristal" less correct than "Crystal"? I feel like I am, but please spell it out for the record :D

@stim371
Copy link
Contributor

stim371 commented Jan 5, 2025

It looks like the list is of Dota 2 Heroes, and the character name is Crystal Maiden.

gioboa
gioboa approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peruzzoarthur LGTM
Kudos for your first PR in this project 🥳

@michaelbromley michaelbromley merged commit 0d08246 into typeorm:master Jan 20, 2025
aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
@peruzzoarthur
docs: Update select-query-builder.md (typeorm#10763)
f3172f2 
Crystal Maiden, not Cristal.
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@peruzzoarthur @ThbltLmr
docs: Update select-query-builder.md (typeorm#10763)
0927a60 
Crystal Maiden, not Cristal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbromley michaelbromley michaelbromley approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

documentation

Projects

TypeORM Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peruzzoarthur @michaelbromley @stim371 @gioboa