Skip to content

chore: Update eager-and-lazy-relations.md for better readability. #10757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mguida22 merged 2 commits into from
Feb 28, 2025
Merged

chore: Update eager-and-lazy-relations.md for better readability. #10757

mguida22 merged 2 commits into from
Feb 28, 2025

Conversation

@joeldmyers
Copy link
Contributor

@joeldmyers joeldmyers commented Mar 8, 2024

Description of change

Tweaking copy in eager and lazy relations doc for better readability.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@joeldmyers
Update eager-and-lazy-relations.md
998b6f5 
Tweaking copy in eager and lazy relations doc for better readability.
@joeldmyers joeldmyers changed the title Update eager-and-lazy-relations.md for better readability. chore: Update eager-and-lazy-relations.md for better readability. Mar 8, 2024
gioboa
gioboa approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joeldmyers LGTM
Kudos for your first PR in this project 🥳

@coveralls
Copy link

coveralls commented Jan 20, 2025

Coverage Status

coverage: 72.366% (+0.006%) from 72.36%
when pulling d7d05b0 on joeldmyers:patch-1
into 0d08246 on typeorm:master.

@gioboa
Copy link
Collaborator

gioboa commented Jan 21, 2025

It's ready to be merged I guess

@mguida22 mguida22 merged commit d52ecf6 into typeorm:master Feb 28, 2025
56 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in TypeORM Roadmap Feb 28, 2025
aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
@joeldmyers @michaelbromley
Update eager-and-lazy-relations.md (typeorm#10757)
4b81b3e 
Tweaking copy in eager and lazy relations doc for better readability.

Co-authored-by: Michael Bromley <michaelbromley@users.noreply.github.com>
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@joeldmyers @michaelbromley @ThbltLmr
Update eager-and-lazy-relations.md (typeorm#10757)
75b7dcd 
Tweaking copy in eager and lazy relations doc for better readability.

Co-authored-by: Michael Bromley <michaelbromley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelbromley michaelbromley michaelbromley approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

documentation

Projects

TypeORM Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joeldmyers @coveralls @gioboa @michaelbromley @stim371 @mguida22