Skip to content

fix: preserve useIndex when cloning a QueryExpressionMap (or a QueryBuilder) #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alumni merged 2 commits into from
Jul 4, 2025
Merged

fix: preserve useIndex when cloning a QueryExpressionMap (or a QueryBuilder) #10679

alumni merged 2 commits into from
Jul 4, 2025

Conversation

@kettui
Copy link
Contributor

@kettui kettui commented Feb 2, 2024 •
edited
Loading

Description of change

Make sure that the useIndex property is copied over when calling QueryExpressionMap#clone

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

gioboa
gioboa reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kettui
I added this fix to the TypeORM board

@gioboa
Copy link
Collaborator

gioboa commented Jan 21, 2025

Fixes: #10678

@gioboa gioboa added the size-s Simple tasks that require minimal effort. Estimated effort: 1-2 hours. label Jan 24, 2025
@Yuliang-Lee
Copy link

Yuliang-Lee commented Jul 2, 2025

why not merge this bugfix？

gioboa
gioboa approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kettui for your help 👏

@alumni alumni merged commit 66ee307 into typeorm:master Jul 4, 2025
@github-project-automation github-project-automation bot moved this from Proposed to Done in TypeORM Roadmap Jul 4, 2025
@kettui kettui deleted the bugfix/query-expression-map-clone-useindex branch August 20, 2025 15:59
ThbltLmr pushed a commit to ThbltLmr/typeorm that referenced this pull request Dec 2, 2025
@kettui @ThbltLmr
fix: preserve useIndex when cloning a QueryExpressionMap (or a Quer…
c92338c 
…yBuilder) (typeorm#10679)

* fix: preserve useIndex when cloning a QueryExpressionMap

Closes typeorm#10678

* test: add test related to issue typeorm#10678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alumni alumni alumni approved these changes

@gioboa gioboa gioboa approved these changes

Assignees

No one assigned

Labels

size-s Simple tasks that require minimal effort. Estimated effort: 1-2 hours.

Projects

TypeORM Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kettui @gioboa @Yuliang-Lee @alumni