RFC: Defining SemVer for Published Types#1158
Closed
chriskrycho wants to merge 51 commits intomasterfrom
Closed
Conversation
This was referenced Jun 3, 2020
This was referenced Jun 8, 2020
chriskrycho
commented
Jun 15, 2020
pzuraq
approved these changes
Jul 2, 2020
pzuraq
left a comment
There was a problem hiding this comment.
Overall this RFC is excellent, great job @chriskrycho and the rest of the Typed Ember team 😄 all my comments are minor, this sounds like a great path forward.
Thanks to @pzuraq for flagging these up!
dfreeman
approved these changes
Jul 2, 2020
Contributor
dfreeman
left a comment
There was a problem hiding this comment.
Thanks for all the hard work you've put into this, @chriskrycho!
Thanks to @dfreeman for catching these! Co-authored-by: Dan Freeman <dfreeman@salsify.com>
- Use the example from Google's writeup for the details of the breaking change, and add playground links for it. - Correct an error around how a forward-compatibility shim layer would work (thanks to @dfreeman for the fix).
Thanks to @dfreeman for relevant suggestions!
mike-north
reviewed
Jul 12, 2020
Member
Author
|
Thanks for the review, @mike-north! Great comments and call-outs across the board. I will address them as soon as possible in comments and revisions—but almost certainly not before Friday. |
Co-authored-by: James C. Davis <jamescdavis@gmail.com> Co-authored-by: Chris Krycho <hello@chriskrycho.com>
I just can't handle seeing `--` in rendered text.
18 tasks
dfreeman
approved these changes
Dec 8, 2020
chriskrycho
added a commit
to semver-ts/semver-ts
that referenced
this pull request
Dec 9, 2020
37 tasks
25 tasks
25 tasks
This was referenced Mar 19, 2021
Member
Author
|
Closing this… in favor of emberjs/rfcs#730! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RFC proposes a set of guidelines and tooling recommendations for managing changes as addons adopt TypeScript throughout the Ember ecosystem, as part of the path to making TypeScript a first-class citizen in Ember as a whole.
Rendered RFC text
Thanks to @dfreeman, @jamescdavis, @rwjblue, @pzuraq, and @mike-north for many discussions of the constraints here!
Notes
This RFC does not attempt to solve—
@types/DefinitelyTyped)These concerns will be addressed in future RFCs.
While the detailed recommendations here are specific to the Ember ecosystem, we believe these recommendations will also be useful for the TypeScript ecosystem more broadly, with tweaks as appropriate to other ecosystems!
On (2): it is an explicit goal of mine for this process (and follow-on work to land in Ember proper) that we be able to extract the definitions laid out here into a dedicated resource defining Semantic Versioning for TypeScript Libraries.