Pin codecov==2.0.5 until fixed #831
Conversation
|
Wow, thanks for tracking this down. I've recently been working on #830 and was wondering why codecov was not getting results from the appveyor builds. |
|
Yeah, we'll see. I don't know if this is the sort of thing that gets accepted but that's what the codecov/support#402 original reporter did with conda. :[ |
rodrigc
left a comment
There was a problem hiding this comment.
You definitely fixed the problem.
Without your fix: https://ci.appveyor.com/project/adiroiban/twisted/build/trunk-3370/job/n4khorbeg540wo7m
fails to upload to codecov.
With your fix: https://ci.appveyor.com/project/adiroiban/twisted/build/trunk-3371/job/1exsed6g7bc5g0ig
succeds upload to codecov.
Thanks for tracking this down and submitting the fix!!
|
Sweet, I broke some CGI tests... on one system... That should be a fun one for me to track down next week. :[ I was getting so excited to get back to my actual bug fixes. |
|
You didn't break those tests, looks like there is some instability on that builder. |
|
Thanks for the patch, you are now at http://twistedmatrix.com/highscores/ ! |
|
Why don't I see a codecov status on this build? I was all excited to see the coverage go up. Do we have to wait until there's a baseline on Normally I'd suggest pinning with |
|
I assume no coverage because nothing that gets coverage checked was changed? And yes, to releases I believe. At least it seems pretty simpler for them to fix unless there was a good reason to disable AppVeyor. |
* First pass at tox/pytest/codecov/travis/appveyor * Add versioneer * Drop py37 on windows until twisted supports it; use 3.6 for dist * use py3.6 for dist on travis * add get_version.py for AppVeyor * skip 3.5 on AppVeyor due to it being 3.5.3 * update requirements.test.txt * print python version in codecov tox env * tidy tox.ini * require tox 3.1 * try again for 3.6 for dist... * try again for appveyor * try again for appveyor... again * tidy appveyor.yml * fix actual tests on appveyor * Add badges to README.rst * twisted==18.9.0rc1 and py35/37 testing on AppVeyor * First pass at a circle config * try to fix circle templates * again * Revert "again" This reverts commit 2eb1ed6. * just checking * virtualenv for circle * $PYTHON -> python3 * correct to .circleci/pyenvinstall.py * correct to python3 * add missing checkout step for osx * decode pyenv list * rework aliases * fix yaml errors * fix yaml errors * fix yaml errors * try to cache pyenv * cache brew and pyenv together * skip existing when pyenv installing * pyenv update * tray again for caching * and maybe cache this time * Revert "pyenv update" This reverts commit 88828bf. * this is weird * hmmph * eehhh * ... * ,,, * just explicitly define the pyenv python version * --- * ugh * env vars wrong all this time * once more * workaround * 2.1 * Rework .circleci/config.yml to version 2.1 * names and environment for osx * take 2 * add dist jobs * drop useless steps indirection * $PYENV_PYTHON_VERSION -> << parameters.pyenv_python_version >> * correct artifact path on circle * use specified pyenv python version directly for cache key * Set PATH directly in environment * separate codecov to it's own step * correct previous * Revert "correct previous" This reverts commit 104902d. * Revert "Set PATH directly in environment" This reverts commit b406625. * Add Circle build status badge * codecov --verbose * Revert "codecov --verbose" This reverts commit 0dddff3. * Add CIrcleCI variables to passenv * codecov==2.0.5 codecov/codecov-python#138 twisted/twisted#831 https://twistedmatrix.com/trac/ticket/9196 https://github.com/codecov/support/issues/402 * Revert "codecov==2.0.5" This reverts commit ba6dcd5. * WIP * Test against both PyQt5 and PySide2 * attempt at unique names on circle again with qtness * take two at circle names * pick pyqt5 as qtness for dist * pass through qtness * hacky fix for dist on circle# * add missing qtness passthrough for osx * Update requirements.test.txt * Update requirements.tox.txt
https://twistedmatrix.com/trac/ticket/9196
https://github.com/codecov/support/issues/402