CodSpeed Performance Report

Merging #12465 will improve performances by 2.26%

_{Comparing uedvt359:trunk (2c92aca) with trunk (aedee3e)}

Summary

⚡ 1 improvements
✅ 35 untouched benchmarks

Benchmarks breakdown

Review comments from @glyph addressed in push c5caa41:

• moved from top-level logger namespace to twisted.logger.rsyslog package
• inlined constants from python's syslog stdlib / #include<syslog.h>

addressed in push 6881912:

• documentation

This still leaves:

• unit tests

I realize that log messages are kind of a special case in terms of eager delivery being really important, but the reactor is already eager, and shouldn't block; have you considered using, or at least supporting, twisted's built-in UDP support?

I would prefer to use Twisted's nonblocking implementation, but I'm not sure how exactly, so I chose to simply use a socket for now. I will look into it again.

rSyslog is allowed over TCP as well, so a solution should work with both transports.

I'm setting this branch to reviewable, because I need some help with the tests, please. I don't understand how I can fake a reactor for my use case.

The CI also wants me to add MyPy type hints - something I am failing at (and could use some hints for) as well :|

pinging @glyph, since you already looked at the original issue.

This wasn't getting looked at because I tend to exclude things with failing tests when I look at the review queue.

No worries about the delay.

Let's maybe find some time to pair program on this, if you have any

I'd love to!