Conversation
Remove Google analytics as a drive-by change.
CodSpeed Performance ReportMerging #12384 will not alter performanceComparing Summary
|
| } | ||
| </script> | ||
|
|
||
| <script src="stable-link.js" type="text/javascript"></script> |
There was a problem hiding this comment.
Happy to see the google analytics removed.
Just asking
Does moving the script to a separate file improves the performance ?
There was a problem hiding this comment.
I don’t believe it particularly improves performance, no
adiroiban
left a comment
There was a problem hiding this comment.
Thanks for the changes
I have reviewed the result at https://twisted--12384.org.readthedocs.build/en/12384/api/twisted.logger.html
I prefer to pin the pydoctor dependency.
This needs to have a src/twisted/newsfragments/12384.misc to let our release notes processing tools know that it should not expect a public release for this PR
Other than that, only minor comments
While reviewing, I have observed something that is not specific to this PR. The issue is also found on trunk.
The source links for the stable branch are alwasy to HEAD, instead of linking to the branch.
Most probably this is not a pydoctor issue, but an issue with the way we build the api docs
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
|
Are we good here ? |
This is true only for the tox environment, for the production Twisted uses correct paths: Line 195 in a0175bb |
Other than that, I think that this is ready to merge. Thanks for the update! |
Scope and purpose