Skip to content

#6597 IPv6 multicast support#12360

Merged
glyph merged 28 commits intotrunkfrom
6597-ipv6-multicast
Nov 13, 2024
Merged

#6597 IPv6 multicast support#12360
glyph merged 28 commits intotrunkfrom
6597-ipv6-multicast

Conversation

@glyph
Copy link
Member

@glyph glyph commented Nov 7, 2024

Scope and purpose

Fixes #6597

Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.

Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.

Add mentions of things that are not covered here and are planed to be done in separate PRs.

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 7, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #12360 will not alter performance

Comparing 6597-ipv6-multicast (e702117) with trunk (f10c1cf)

Summary

✅ 25 untouched benchmarks

@glyph
Copy link
Member Author

glyph commented Nov 12, 2024

Right now I'm not using our interface-enumeration code because I think it's not quite sufficient on Windows, just assuming "loopback" starts with lo everywhere. I filed an issue in CPython so that in a few years maybe we can use that instead:

python/cpython#126713 (comment)

@glyph glyph marked this pull request as ready for review November 13, 2024 01:37
@chevah-robot chevah-robot requested a review from a team November 13, 2024 01:37
adiroiban
adiroiban approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes looks good. I left a few minor comments.

I know what multicast is, but I newer wrote multicast applications...

I don't know if anyone else will have tim to review this, so I did a quick review.

As long as the automated tests pass, I think that we can mege this.

Thanks again for updating ipv6 support

Not sure if we should mention multicast support on the narravite documentation page https://docs.twisted.org/en/stable/core/howto/udp.html#ipv6

@glyph
Copy link
Member Author

glyph commented Nov 13, 2024

Thanks for the thorough review @adiroiban . I think I have addressed everything completely. A great example of how a very detailed review (and indeed bugfix) can come from somebody with relatively little experience in a particular area.

@glyph glyph merged commit a6c0e2d into trunk Nov 13, 2024
@glyph glyph deleted the 6597-ipv6-multicast branch November 13, 2024 20:34
@glyph glyph mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees

No one assigned

Labels

needs-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IPv6 address literals support for IReactorMulticast.listenMulticast, IMulticastTransport.joinGroup, IMulticastTransport.joinGroup and others

3 participants

@glyph @adiroiban @chevah-robot