Update README.rst to reference python 3.8+#12354
Merged
Conversation
CodSpeed Performance ReportMerging #12354 will not alter performanceComparing Summary
|
Contributor
|
Looks good, but I spotted a couple of other places in the documentation that should be updated too: |
Contributor
|
Actually the second of those is just in an example release candidate announcement, so isn't a problem. |
Member
Author
|
As a side topic, has removing instructions for porting from Python 2 been considered? Thanks. |
adiroiban
reviewed
Nov 6, 2024
adiroiban
reviewed
Nov 6, 2024
adiroiban
reviewed
Nov 6, 2024
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Colin Watson <cjwatson@debian.org>
altendky
commented
Nov 6, 2024
| ------------- | ||
|
|
||
| Twisted is an event-based framework for internet applications, supporting Python 3.6+. | ||
| Twisted is a Python event-based framework for internet applications. |
Member
Author
There was a problem hiding this comment.
Or maybe you want to twiddle it a bit more.
Suggested change
| Twisted is a Python event-based framework for internet applications. | |
| Twisted is an event-based Python framework for internet applications. |
or...
Suggested change
| Twisted is a Python event-based framework for internet applications. | |
| Twisted is an event-based framework for Python internet applications. |
or...
ok, i'll stop now. at this point they all feel a little bit odd now that i've thought about them too much. :]
i'm also fine as-is. change, approve, do what you will.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
thanks for pointing out the inconsistency @kursataktas
#12353 (comment)
Fixes #
Add a few words about why this PR is needed and what is its scope.
If the associate ticket(s) fully explain the need you can just refer to it/them.
Add any comments about trade-offs (if any) made in this PR and the reasoning behind them.
Add mentions of things that are not covered here and are planed to be done in separate PRs.
Contributor Checklist:
This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.
Below is a non-exhaustive list (as a reminder):
please review.Our bot will trigger the review process, by applying the pending review label
and requesting a review from the Twisted dev team.