#11893 Move iocp dependency to Windows specific soft dependencies.#12144
Merged
#11893 Move iocp dependency to Windows specific soft dependencies.#12144
Conversation
Member
Author
|
I think that this is ready for a first round of reviews needs-review |
glyph
approved these changes
Jun 17, 2024
Member
glyph
left a comment
There was a problem hiding this comment.
I agree, we should support the most minimal non-native-deps installation on Windows as we do on other platforms.
CodSpeed Performance ReportMerging #12144 will not alter performanceComparing Summary
|
Member
Author
|
Thanks for the review. I have enabled the auto-merge for this PR. I have added the "release-blocker" tag to this PR, so that when we do the release, it can server as a reminder to add a top release note about explicit twisted-iocpsupport install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11893
This is done so that
pip install twistedwill no longer depend on our IOCP support.The IOCP support package might get outdate, as we don't have an active maintainer for Twisted IOCP reactor.
This is a backward incompatible change... as those who want IOCP support, will now have to install it expliclitly.
I am not sure how to make this change in a backward compatible way.
What we can do, is to add a big warning at the top of the release notes and in the release email
How to test
Manual checks without IOCP
On Windows, get this branch and then run
pip install .Check that IOCP is not installed
You can run the same test on Linux, to make sure IOCP is not installed... just to be extra safe :)
Manual checks with IOCP
On Windows, get this branch and then run
pip install .[windows-platform]Check that IOCP is installed
CI checks
The iocp support is automatically installed in our CI via tox "-window-" environment marker
https://github.com/twisted/twisted/actions/runs/8895048158/job/24424587427?pr=12144#step:10:35