Skip to content

Move operator definitions to objects#4543

Merged
fabpot merged 10 commits into
twigphp:3.xfrom
fabpot:operator-classes
Feb 14, 2025
Merged

Move operator definitions to objects#4543
fabpot merged 10 commits into
twigphp:3.xfrom
fabpot:operator-classes

Conversation

@fabpot

@fabpot fabpot commented Jan 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@fabpot fabpot force-pushed the operator-classes branch 5 times, most recently from 4461487 to bd7a8df Compare January 19, 2025 18:42
Comment thread doc/deprecated.rst Outdated
Comment thread src/ExtensionSet.php Outdated
Comment thread src/Operator/OperatorInterface.php Outdated
Comment thread src/Operator/OperatorInterface.php Outdated
Comment thread src/Operator/OperatorInterface.php Outdated
Comment thread src/Extension/ExtensionInterface.php Outdated
Comment thread src/ExpressionParser.php Outdated
Comment thread src/Operator/Binary/AbstractBinaryOperator.php Outdated
Comment thread src/ExpressionParser.php Outdated
Comment thread src/Operator/Operators.php Outdated
Comment thread src/Operator/Operators.php Outdated
Comment thread src/Operator/Operators.php Outdated
Comment thread src/Operator/Operators.php Outdated
Comment thread src/Operator/Operators.php Outdated
@fabpot fabpot force-pushed the operator-classes branch 5 times, most recently from 1749107 to 3d0e2f3 Compare January 26, 2025 14:28
@fabpot

fabpot commented Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

New iteration where I have moved most pseudo-operators (logic hardcoded in ExpressionParser) to real operators like any other ones (think |, ., [, (, ??, ...).

@fabpot fabpot force-pushed the operator-classes branch 5 times, most recently from 339a8c3 to 4bf41b7 Compare January 26, 2025 14:53
Comment thread doc/operators_precedence.rst Outdated
@fabpot fabpot force-pushed the operator-classes branch 2 times, most recently from 35ef5c7 to 0704840 Compare January 29, 2025 11:27
Comment thread src/ExpressionParser.php Outdated
Comment thread src/Operator/Ternary/AbstractTernaryOperator.php Outdated
Comment thread src/Operator/Ternary/AbstractTernaryOperator.php Outdated
Comment thread src/Operator/Unary/ParenthesisUnaryOperator.php
Comment thread doc/operators_precedence.rst Outdated
Comment thread src/ExpressionParser.php Outdated
Comment thread src/Node/Expression/ListExpression.php Outdated
Comment thread src/Lexer.php Outdated
Comment thread src/Lexer.php Outdated
Comment thread src/TokenParser/AbstractTokenParser.php Outdated
@fabpot fabpot force-pushed the operator-classes branch 2 times, most recently from dc96f57 to ec728b6 Compare January 29, 2025 18:43
Comment thread CHANGELOG Outdated
@fabpot fabpot force-pushed the operator-classes branch 2 times, most recently from c9cc79d to df5904e Compare February 1, 2025 14:44
Comment thread src/Parser.php Outdated
@fabpot fabpot force-pushed the operator-classes branch 5 times, most recently from 72748e3 to 10f2090 Compare February 13, 2025 12:21
@fabpot

fabpot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor Author

I think I've taken all comments into account now.
Ready for maybe a lst round of reviews?

@nicolas-grekas nicolas-grekas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very high overview :)

Comment thread src/ExpressionParser/ExpressionParserInterface.php
Comment thread src/ExpressionParser/ExpressionParsers.php Outdated
Comment thread src/ExpressionParser/ExpressionParsers.php
Comment thread src/ExpressionParser/ExpressionParsers.php Outdated
Comment thread src/ExpressionParser/ExpressionParsers.php Outdated
@fabpot fabpot merged commit 1ea5ac6 into twigphp:3.x Feb 14, 2025
@fabpot fabpot deleted the operator-classes branch February 14, 2025 07:51
smnandre added a commit to symfony/ux that referenced this pull request Feb 22, 2025
…Parser) (smnandre)

This PR was merged into the 2.x branch.

Discussion
----------

[TwigComponent] Fix Twig 3.21 deprecations (getExpressionParser)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

Following twigphp/Twig#4543

Commits
-------

dfeb323 [TwigComponent] Fix getExpressionParser deprecations (Twig 3.21)
titouanmathis added a commit to studiometa/twig-toolkit that referenced this pull request Jun 17, 2025
titouanmathis added a commit to studiometa/twig-toolkit that referenced this pull request Jun 17, 2025
titouanmathis added a commit to studiometa/twig-toolkit that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants