Add support for recursive loops#4153
Merged
Merged
Conversation
This was referenced Jul 27, 2024
Contributor
|
Should loop(loop.parent) be forbidden / prevented ? (or any infinite récursion if this syntax has not the effect i anticipate) |
e0ebf28 to
8ba877f
Compare
Contributor
Author
My first reaction was that we should not do anything (PHP does nothing to prevent such infinite loops for instance). But as this is a templating engine that can be used by end users that you don't control, I've limited the depth to 50 (50 is kind of arbitrary, but maybe a good balance between valid use cases and malicious usage of a recursive loop). |
smnandre
reviewed
Jul 27, 2024
stof
reviewed
Jul 30, 2024
fabpot
added a commit
that referenced
this pull request
Jul 31, 2024
This PR was merged into the 4.x branch. Discussion ---------- add type-hints to the LoopContext constructor see #4153 (comment) Commits ------- 27e137a add type-hints to the LoopContext constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3416
Fixes #4144