Skip to content

add type-hints to the LoopContext constructor#4168

Merged
fabpot merged 1 commit into
twigphp:4.xfrom
xabbuh:pr-4153
Jul 31, 2024
Merged

add type-hints to the LoopContext constructor#4168
fabpot merged 1 commit into
twigphp:4.xfrom
xabbuh:pr-4153

Conversation

@xabbuh

@xabbuh xabbuh commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

@stof

stof commented Jul 31, 2024

Copy link
Copy Markdown
Member

should __invoke be typed as iterable or no ?

@xabbuh

xabbuh commented Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

@stof makes sense I guess

@fabpot

fabpot commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Thank you @xabbuh.

@fabpot fabpot merged commit 96b11f7 into twigphp:4.x Jul 31, 2024
@xabbuh xabbuh deleted the pr-4153 branch July 31, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants