Conversation
|
Thank you @nicolas-grekas. |
|
@nicolas-grekas After this change was merged, when running our test suite for the
We are referencing Removing the following line from class_alias('Twig_SimpleFilter', 'Twig\TwigFilter', false);But it I'm not sure it's that simple. Based on a cursory examination, it appears like Twig/SimpleFilter.php:23 and Twig/Filter.php:142 are the cause of the error, because one includes the other and they both declare an alias for If you'd like me to open a proper issue instead of bringing this up on a closed PR, let me know and I'll make it happen. |
|
Also, it seems odd that the test suite for this bundle didn't fail; shouldn't there be unit tests somewhere instantiating a filter to test it can be instantiated? |
|
Please don't comment on closed PR, it makes tracking harder for everyone. |
The 2.x-only part of #2484