Skip to content

Eliminate the fixity-th cabal flag#954

Merged
mrkkrp merged 1 commit intomasterfrom
eliminate-fixity-th-flag
Jan 3, 2023
Merged

Eliminate the fixity-th cabal flag#954
mrkkrp merged 1 commit intomasterfrom
eliminate-fixity-th-flag

Conversation

@mrkkrp
Copy link
Copy Markdown
Member

@mrkkrp mrkkrp commented Jan 3, 2023

Close #927, close #941.

The flag caused problems on GHC 9.4 and generally was a magnet for bugs. We are going to try to use file-embed unconditionally and make parsing more efficient instead.

@mrkkrp mrkkrp requested a review from amesgen January 3, 2023 14:37
@mrkkrp mrkkrp force-pushed the eliminate-fixity-th-flag branch 2 times, most recently from a3d7d71 to 5a7898e Compare January 3, 2023 14:43
amesgen
amesgen approved these changes Jan 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one occurrence of fixity-th left in default.nix for Ormolu Live:

ormolu/default.nix

Line 31 in 5a7898e

flags.fixity-th = false;

but it will be removed in #940 either way.

@mrkkrp mrkkrp force-pushed the eliminate-fixity-th-flag branch 2 times, most recently from d498da8 to 374773a Compare January 3, 2023 15:09
@mrkkrp @amesgen
Eliminate the fixity-th cabal flag
9f828e8 
The flag caused problems on GHC 9.4 and generally was a magnet for bugs, see
#941 and
#927. We are going to try to use
file-embed unconditionally and make parsing more efficient instead.

Co-authored-by: amesgen <alexander.esgen@tweag.io>
@mrkkrp mrkkrp force-pushed the eliminate-fixity-th-flag branch from efa3bf3 to 9f828e8 Compare January 3, 2023 15:11
@mrkkrp mrkkrp merged commit b545930 into master Jan 3, 2023
@mrkkrp mrkkrp deleted the eliminate-fixity-th-flag branch January 3, 2023 15:33
This was referenced Jan 4, 2023
Closed
Merged
Closed
@georgefst georgefst mentioned this pull request Jan 17, 2023
Merged
@dhess dhess mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amesgen amesgen amesgen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@mrkkrp @amesgen