Conversation
73b67a5 to
4470f70
Compare
073e058 to
d9af426
Compare
Merged
d9af426 to
119dcc6
Compare
23a13e2 to
3e7308c
Compare
mrkkrp
reviewed
Jan 23, 2023
Member
mrkkrp
left a comment
There was a problem hiding this comment.
Terrific job, as usual! Other than the request to preserve Ormolu live source code, I have just two minor comments.
3e7308c to
bcc4a4c
Compare
mrkkrp
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitdirectory is no longer available, sogitrevcan't work. Hence, we are now passing in the current commit rev (if it exists) as an environment variable at build time.nixConfiginflake.nix. This way, one does no longer have to globally configure it..envrcfiles for nix-direnv for convenience, but this is not super important.