Add back sitcc to ExplicitTuple.p_arg#868
Conversation
|
cc @amesgen, just because you did the ghc-lib-parser-9.2 upgrade |
|
Can you come up with an example that would demonstrate the difference between the current behavior and the behavior with |
|
so I found some differences with do-blocks in tuple sections: -- without sitcc
x =
[ (do
x <- asdf
return x,)
]
x =
[ (do
x <- asdf
return x,do
x <- asdf2
return x,)
]
-- with sitcc
x =
[ (do
x <- asdf
return x,)
]
x =
[ (do
x <- asdf
return x,do
x <- asdf2
return x,)
]without This only comes up with tuple sections because
I know (3) probably doesn't matter to you, but in combination with (1), i don't see any reason not to do it, and it has a nice side benefit of helping downstream. plus, i suspect that if ormolu changes something around styling tuples here, this |
|
Thanks! |
sitccwas removed as part of theghc-lib-parser-9.2upgrade (#779), but it looks like that was erroneous; the only change that needed to happen inp_largwas the removal oflocated. This causes problems infourmoluwith leading commas (see fourmolu/fourmolu#148 (comment)), and this fixes it. I'm not quite sure how to come up with a failing test case for this in ormolu, but I'm fairly certain that the removal ofsitccis incorrect, and may cause other unexpected behaviors.