Merged
Conversation
4e0087b to
341db9a
Compare
51cc038 to
4635385
Compare
fa44f4b to
428a206
Compare
mrkkrp
approved these changes
Oct 19, 2021
data/examples/declaration/value/function/arrow/proc-do-complex-out.hs
Outdated
Show resolved
Hide resolved
428a206 to
fceb4a7
Compare
597d0c8 to
3adde79
Compare
3adde79 to
1785ebf
Compare
Contributor
Author
|
Upgrading from 9.2.1-rc1 to 9.2.1 only required two minor changes: https://gist.github.com/amesgen/c77ab54959903ebc5e3734ad630e8c93 The only thing missing now is mrkkrp/ghc-syntax-highlighter#24 |
Member
|
Is there something that still prevents us from testing with 9.2.1 on CI? |
Contributor
Author
|
430af6a to
f83c47f
Compare
mrkkrp
reviewed
Nov 16, 2021
Member
mrkkrp
left a comment
There was a problem hiding this comment.
Here is another round of review, since I saw some new changes. I think we are very close to finally merging this into master.
4bfdcea to
d1ad5fe
Compare
3cfdffd to
ffe3c9b
Compare
ffe3c9b to
2e52dba
Compare
mrkkrp
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #794
Closes #768 (promoted infix data constructors)
Closes #659 Closes #709 Closes #705 (
RecordDot*stuff)The most significant in
ghc-lib-parser-9.2is EPA (exact print annotations). This blog post gives a good overview. A few points:Located, but rather in aGenLocated (SrcSpanAnn' a), whereSrcSpanAnn' ~ (a, SrcSpan).GHC.Parser.Annotationgives a good overview of the new combinators for these types.Annsstuff.NoExtField.EDIT: This PR introduces a benign style issue: #810