preserve CTYPE pragmas in data declarations#725
Merged
Conversation
077bf51 to
79d9c24
Compare
Contributor
Author
|
Maybe we could use safe-wild-cards in selected places where we want to ensure to actually use all available fields. |
Member
|
|
mrkkrp
approved these changes
Aug 7, 2021
79d9c24 to
acf2290
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #689
This targets the ghc-9.0 branch right now, which will have to change as soon as #722 has been merged.
The
dd_cTypefield ofHsDataDefnhad been ignored previously, which means thatCTYPEpragmas were simply dropped on formatting.As an aside: The
dd_ctxtis also ignored, but the corresponding extension (DatatypeContexts) is deprecated, so I don't know if it is even worth to respect it.