Conversation
Contributor
Author
|
Overview:
Two questions to be resolved:
I am not sure whether these are considered to be bugs, and if so, whether they should block this PR. EDIT see this comment for an update. |
This was referenced Jul 26, 2021
Contributor
Author
|
Update to the questions above: We decided that 2. is OK, and created #726 to track 1. |
mrkkrp
reviewed
Aug 7, 2021
mrkkrp
approved these changes
Aug 7, 2021
|
Question: I'm running |
Contributor
Author
|
Ok thanks! I just saw the lib-parser scroll by for 9.0.1, and was worried it might be inconsistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #688
Closes #452
Closes #720
Closes #480
See the comment below for an overview.