WIP: Migrate to ghc-lib-parser-9.0.1#720
Closed
berberman wants to merge 3 commits intotweag:masterfrom
Closed
Conversation
Member
|
Thanks for starting this!
I don't see any mention of |
Merged
Contributor
|
Thank you for this! I started to work on this independently (probably should've created a draft PR earlier), and I think #722 mostly finished by now. Your remark that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #688.
This PR is very unpolished, though currently it builds, and all tests can pass with
cfgUnsafe = True. Since I'm not very familiar with the changes in ASTs since GHC 9.0, basically I write these code following the hints from the powerful type system and intuition. It would be great if someone could help :)TODO
ImpredicativeTypesto typecheckOrmolu.Diff.ParseResultin GHC 9 (perhaps something related to simplified subsumption?)cfgUnsafe = FalseI also have a question that is there any use case of
BufSpans in ormolu? They are now ignored.