Skip to content

No cabal-doctest in Setup.hs#335

Merged
utdemir merged 1 commit intomasterfrom
fd/no-cabal-doctest
Jun 30, 2021
Merged

No cabal-doctest in Setup.hs#335
utdemir merged 1 commit intomasterfrom
fd/no-cabal-doctest

Conversation

@facundominguez
Copy link
Copy Markdown
Member

This allows projects to depend on linear-types without depending on cabal-doctest

@facundominguez
Copy link
Copy Markdown
Member Author

I'm submitting this in case you want to get rid of cabal-doctest. Otherwise, feel free to close this PR.

Copy link
Copy Markdown
Contributor

@utdemir utdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the previous Setup.hs was a mistake, we were supposed to have our doctests disabled and there's no reason to try to pull it here.

@facundominguez facundominguez added the merge-queue merge on green CI label Jun 28, 2021
@facundominguez
Copy link
Copy Markdown
Member Author

How do we get the CI checks unstuck here?

@utdemir utdemir force-pushed the fd/no-cabal-doctest branch from ec0b5aa to 086278f Compare June 29, 2021 23:50
@utdemir utdemir merged commit 0e2824a into master Jun 30, 2021
@utdemir utdemir deleted the fd/no-cabal-doctest branch June 30, 2021 00:09
@utdemir
Copy link
Copy Markdown
Contributor

utdemir commented Jun 30, 2021

How do we get the CI checks unstuck here?

CI setup has changed recently (#332), so I just had to rebase this branch on top of a newer master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue merge on green CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants