Upgrade Stackage nightly and stop using Nix with Stack#332
Merged
Conversation
aspiwack
approved these changes
Jun 24, 2021
Member
aspiwack
left a comment
There was a problem hiding this comment.
Much appreciated.
Small change to the CI action below.
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
93c8a34 to
7d23769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(opinionated PR, so please do discuss if you disagree)
The latest Stackage nightly (
2021-06-21) is the first resolver with GHC 9.0.1, so nowstackcan install the compiler itself, without us having to provide it via Nix.I gave it a go and saw that on a fresh Ubuntu machine
stackwas able to buildlinear-basefrom scratch. I think this would be a welcome change for people who wants to tinker onlinear-basewithout having to install Nix. We still have the bug in #264, sostackcan not run our tests.Nix users can still use cabal, or manually pass
--nixflag tostack(or use the global configuration file).I also created a small CI step to ensure that the project can be built with
stack.Since a GHC 9 nightly is out, we should also aim to get
linear-baseinto Stackage. I will create a separate issue for that.