Skip to content

Add a Github action ci#322

Merged
aspiwack merged 1 commit intomasterfrom
ci/github-action
Apr 9, 2021
Merged

Add a Github action ci#322
aspiwack merged 1 commit intomasterfrom
ci/github-action

Conversation

@aspiwack
Copy link
Copy Markdown
Member

@aspiwack aspiwack commented Apr 9, 2021

Now that we don't need to build GHC ourselves for the sake of
linear-base to work, we don't need to lock a super beefy runner for 1h
from time to time.

On the other hand, the buildkite runner didn't run ci for
contributions outside of Tweag. Having a Github-action based ci will
be better for contributors.

I'll remove the Buildkite ci in a separate PR.

@aspiwack aspiwack force-pushed the ci/github-action branch 2 times, most recently from d65f076 to 92d2eec Compare April 9, 2021 13:34
@aspiwack
Copy link
Copy Markdown
Member Author

aspiwack commented Apr 9, 2021

Auto-reviewing because I can. Let me just merge.

@aspiwack aspiwack force-pushed the ci/github-action branch 2 times, most recently from 32d8b7f to 3d701c3 Compare April 9, 2021 14:35
@aspiwack
Copy link
Copy Markdown
Member Author

aspiwack commented Apr 9, 2021

I chose to make a few adjustments before merging, making my previous comment a lie.

  • Take the Cabal dependencies to be a separate step (in large part so that we can observe the time it takes)
  • Add a test that we are building the Haddock
  • Add caching of Cabal dependencies

Now that we don't need to build GHC ourselves for the sake of
linear-base to work, we don't need to lock a super beefy runner for 1h
from time to time.

On the other hand, the buildkite runner didn't run ci for
contributions outside of Tweag. Having a Github-action based ci will
be better for contributors.
@aspiwack aspiwack merged commit b11a8e5 into master Apr 9, 2021
@aspiwack aspiwack deleted the ci/github-action branch April 9, 2021 15:02
aspiwack added a commit that referenced this pull request Apr 9, 2021
It has been obsoleted by the Github-action ci. See #322.
@aspiwack aspiwack mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant