Skip to content

Fix TypeError in sliders.js#442

Merged
XhmikosR merged 1 commit intomasterfrom
typeerror
Mar 16, 2014
Merged

Fix TypeError in sliders.js#442
XhmikosR merged 1 commit intomasterfrom
typeerror

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Mar 7, 2014

Fixes TypeError: slider.style.webkitTransform is undefined

/CC @connors @fat

@XhmikosR XhmikosR mentioned this pull request Mar 7, 2014
@cvrebert cvrebert added the js label Mar 7, 2014
@cvrebert cvrebert added this to the 2.0.2 milestone Mar 7, 2014
@XhmikosR
Copy link
Copy Markdown
Member Author

This breaks sliders in webkit browsers on desktop, at least.

@connors
Copy link
Copy Markdown
Collaborator

connors commented Mar 12, 2014

cc @connor

@XhmikosR
Copy link
Copy Markdown
Member Author

I think instead of doing what I do here, which is clearly wrong since it breaks at least Chrome on desktop, we should just add an array of properties for the transition; this way we'll be compatible with most browsers and we shouldn't get any TypeErrors.

@XhmikosR XhmikosR closed this Mar 14, 2014
@XhmikosR XhmikosR deleted the typeerror branch March 14, 2014 05:04
@XhmikosR XhmikosR restored the typeerror branch March 14, 2014 07:22
@XhmikosR
Copy link
Copy Markdown
Member Author

I found the proper way to check for webkitTransform until we have a cross browser solution.

@XhmikosR XhmikosR reopened this Mar 14, 2014
XhmikosR added a commit that referenced this pull request Mar 16, 2014
Fix TypeError in sliders.js
@XhmikosR XhmikosR merged commit 96726ad into master Mar 16, 2014
@XhmikosR XhmikosR deleted the typeerror branch March 16, 2014 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants