Merged
Conversation
4 tasks
|
@XhmikosR Partially fixes, not completely fixes. |
Member
Author
|
Fixes just fine for now along with the other PR. |
Contributor
|
👍 |
Member
Author
|
@connor: I can't merge this due to first issue I mention in the description :P |
Collaborator
|
@XhmikosR I just pulled down the branch and everything works fine for me. What browser are you using again? |
Member
Author
|
Let me try again, I might missed refreshing |
Member
Author
|
Yeah, you are right :) I'll merge this, but I wish we had better support for development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #354.
Notes:
1. Unfortunately, for some unknown reason to me yet, the device changer JS doesn't work anymore.2. I specified
compress: truein uglify on purpose so that we see the warnings/CC @connor @connors: can you check out the branch and see why the aforementioned issue happens?
PS. I'll make another PR for JSHInt.