Skip to content

Conversation

@hannahiss
Copy link
Contributor

@hannahiss hannahiss commented Sep 10, 2024

Description

Motivation & Context

The is no label/accessible name for the SVG which has a toolitp.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@hannahiss hannahiss marked this pull request as ready for review September 10, 2024 13:52
hannahiss added a commit to Orange-OpenSource/Orange-Boosted-Bootstrap that referenced this pull request Sep 10, 2024
@julien-deramond julien-deramond self-requested a review September 10, 2024 14:43
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and to @patrickhlauke (see #40756 (comment) thread)

@julien-deramond julien-deramond merged commit a7a45b2 into twbs:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants