Remove explicit heights on form elements#31993
Merged
Conversation
4 tasks
a2a9dc0 to
5dc13b2
Compare
Member
Author
|
Don't merge this yet, I'm doing some tests withs input field heights to confirm this works (already found a bug in the current implementation which was solved in this PR, lol) |
5dc13b2 to
2e947f1
Compare
Member
Author
|
Ok, I made a codepen to check browsers with and it looks like we're ok with this change: https://codepen.io/MartijnCuppens/pen/JjKpbGd?editors=1010 I actually even found out there's a bug with the current implementation: https://codepen.io/MartijnCuppens/pen/PozQbqJ?editors=1010 |
XhmikosR
reviewed
Oct 29, 2020
Member
|
i think this change now made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input heights were initially added in #26820 to fix #18842. Select heights were added to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1560824.
But:
However, removing the explicit height would reintroduce #23307. Luckily, date inputs have a
::-webkit-datetime-editof which we can set the height inem🎉This means, we can safely remove those (min-)heights that seem to cause some issues like #26820 (comment) or #31955 (comment) (this fixes issues when zoomed in/out)
I've kept a min-height for textareas, to keep support for #29124
I didn't apply this change to
.form-file, since this will introduce conflicts with #31955, therefor I'll keep this in draft.