Skip to content

set min-height for form-control textarea#29124

Merged
MartijnCuppens merged 4 commits intotwbs:masterfrom
m5o:forms-textarea-min-height
Aug 18, 2019
Merged

set min-height for form-control textarea#29124
MartijnCuppens merged 4 commits intotwbs:masterfrom
m5o:forms-textarea-min-height

Conversation

@m5o
Copy link
Contributor

@m5o m5o commented Jul 24, 2019 •
edited
Loading

  • set min-height for .form-control textarea
    • prevent user from shrink textarea
    • set minimum height equals default input height
before after
Screenshot 2019-07-24 at 16 40 50 Screenshot 2019-07-24 at 16 41 13
Screenshot 2019-07-24 at 17 36 03 Screenshot 2019-07-24 at 17 35 18

📷 Chrome 75 / Mac OS X 10.14.6

@m5o m5o requested a review from a team as a code owner July 24, 2019 15:17
@ysds
Copy link
Contributor

ysds commented Jul 24, 2019

To fix also #28901, is it better add min-height to .form-control and remove the specific heights?

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Jul 24, 2019

@ysds, that would reintroduce #18842, unless #28917 is merged.

@ysds
Copy link
Contributor

ysds commented Jul 29, 2019 •
edited
Loading

@m5o Would you add the min-height to .form-control and .form-select directory and remove the specific height from those? Also need to modify the sizing options and the combinations with .input-groups.

@m5o m5o force-pushed the forms-textarea-min-height branch from 5078a21 to ba8fa47 Compare July 30, 2019 07:43
@m5o
Copy link
Contributor Author

m5o commented Jul 30, 2019

@ysds done, hopefully as you requested.

🤔 I don't know if, for consistency, it would make sense to set min-height also to .form-file

ysds
ysds approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@ysds ysds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m5o nice, LGTM 👍

@ysds
Copy link
Contributor

ysds commented Aug 5, 2019

.form-file use position: absolute, so would have to use height.

MartijnCuppens
MartijnCuppens requested changes Aug 5, 2019
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox add 2px to its select because of this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1560824, so we should set height on selects unfortunately

@ysds
Copy link
Contributor

ysds commented Aug 6, 2019

umm, confirmed

image

MartijnCuppens
MartijnCuppens reviewed Aug 8, 2019
View reviewed changes
@XhmikosR XhmikosR requested a review from MartijnCuppens August 9, 2019 11:25
@mdo
Copy link
Member

mdo commented Aug 15, 2019

@MartijnCuppens Can you re-review, please?

@XhmikosR
Copy link
Member

XhmikosR commented Aug 16, 2019

Are we sure about backporting this BTW?

@m5o m5o requested a review from a team as a code owner August 17, 2019 11:48
@MartijnCuppens MartijnCuppens force-pushed the forms-textarea-min-height branch from 1ac0108 to 2880992 Compare August 17, 2019 11:49
@MartijnCuppens
Copy link
Member

MartijnCuppens commented Aug 17, 2019

#18842 still seemed to be an issue. I've pushed a working fix (219e1c68ce6405778bcaf865841cc89f3d80b7c6) and also committed a fix for the input groups.

m5o and others added 3 commits August 18, 2019 16:21
@m5o @MartijnCuppens
set min-height for form-control textarea
3ccb722 
* set `min-height` for `.form-control` textarea
  * prevent user from shrink textarea to minimum height
@MartijnCuppens
Fix date heights
0f2797d
@MartijnCuppens
Split up .form-control & .form-select selectors
d6a3162
@MartijnCuppens MartijnCuppens force-pushed the forms-textarea-min-height branch from 31f6a66 to d6a3162 Compare August 18, 2019 14:23
@MartijnCuppens MartijnCuppens merged commit 9452120 into twbs:master Aug 18, 2019
@XhmikosR
Copy link
Member

XhmikosR commented Aug 19, 2019

@MartijnCuppens: this doesn't apply clean on v4-dev-xmr. Can you backport it manually please?

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Aug 19, 2019

I'm afraid we can't backport this easily since .form-controls can be selects too in v4. To make this work we'll need to rewrite quite a lot and this might introduce breaking changes.

This was referenced Feb 15, 2020
Closed
Closed
@m5o m5o deleted the forms-textarea-min-height branch February 16, 2020 11:09
@MartijnCuppens MartijnCuppens mentioned this pull request Mar 10, 2020
Merged
@MartijnCuppens MartijnCuppens mentioned this pull request Mar 31, 2020
Merged
@MartijnCuppens MartijnCuppens mentioned this pull request Oct 27, 2020
Merged
@ffoodd ffoodd mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

+1 more reviewer

@ysds ysds ysds approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

css no-backport-to-v4 v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m5o @ysds @MartijnCuppens @mdo @XhmikosR