Skip to content

Reboot updates#28917

Merged
MartijnCuppens merged 3 commits intomasterfrom
master-mc-reboot-update
Jul 25, 2019
Merged

Reboot updates#28917
MartijnCuppens merged 3 commits intomasterfrom
master-mc-reboot-update

Conversation

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Jun 17, 2019 •
edited
Loading

  • Inherit box-sizing and set box-sizing: border-box; on body
    This makes it possible for 3th party components to use box-sizing: content-box by just applying the box-sizing to the wrapper div.     Nope: Reboot updates #28917 (comment)
  • Remove unsupported browsers fixes (IE10 & Firefox 39-)
  • More consistent comment blocks
  • Reorganise order of some blocks
  • Add height fix for date/month/week/time inputs (Temporal inputs are 2px taller than other textual inputs in Chrome #18842, this was already fixed by adding a height to form controls, with this change we don't need to set the height anymore)
  • Remove redundant type selectors for some pseudo elements
  • Additional resets and theming options for legend
  • Element theming from _code.scss moved to reboot
  • All input fields now have the same borders

Todo:

  • Merge code page with reboot page

Result: https://deploy-preview-28917--twbs-bootstrap.netlify.com/docs/4.3/content/reboot/

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner June 17, 2019 19:01
ysds
ysds reviewed Jun 18, 2019
View reviewed changes
ysds
ysds reviewed Jun 18, 2019
View reviewed changes
ysds
ysds reviewed Jun 18, 2019
View reviewed changes
coliff
coliff reviewed Jul 4, 2019
View reviewed changes
@MartijnCuppens MartijnCuppens requested a review from a team as a code owner July 13, 2019 08:46
@MartijnCuppens MartijnCuppens force-pushed the master-mc-reboot-update branch 6 times, most recently from 12840b0 to cda30cc Compare July 14, 2019 10:51
@mdo
Copy link
Member

mdo commented Jul 16, 2019

Regarding the box-sizing change: #22872

@MartijnCuppens MartijnCuppens force-pushed the master-mc-reboot-update branch from cda30cc to 63c3010 Compare July 21, 2019 07:42
@mdo
Copy link
Member

mdo commented Jul 21, 2019

Last thing I've noticed here is that if we're moving all those styles to Reboot, we need to move the docs content to the Reboot page as well.

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Jul 23, 2019

I'm not sure what to do with the .pre-scrollable class. It's the only class left in _code.scss and I can't document it on the reboot page since it isn't part of it. Should we leave it as only class on the code page and in _code.scss or is it not worth it and can we drop it?

@MartijnCuppens MartijnCuppens mentioned this pull request Jul 24, 2019
Merged
@ysds
Copy link
Contributor

ysds commented Jul 25, 2019

I agree to remove the .pre-scrollable. I'm OK remove it in this PR, but I prefer to separate for clarity.

@MartijnCuppens MartijnCuppens mentioned this pull request Jul 25, 2019
Merged
1 task
@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Jul 25, 2019

I've opened #29135 to drop the class.

@MartijnCuppens MartijnCuppens force-pushed the master-mc-reboot-update branch from 97644aa to d38e925 Compare July 25, 2019 17:00
MartijnCuppens and others added 3 commits July 25, 2019 19:06
@MartijnCuppens
Reboot updates
7b2bed2 
- Remove unsupported browsers fixes
- More consistent comment blocks
- Reorganise order of some blocks
- Add height fix for date/month/week/time inputs (#18842)
- Remove redundant type selectors
- Additional resets and theming options for `legend`
- Add date & color inputs to reboot page
- Use the same borders for text search, text inputs, textareas and date inputs
- Move code styling to reboot
@ysds @MartijnCuppens
Remove duplicate
b97041c
@MartijnCuppens
Merge code page with reboot
bd960cd
@MartijnCuppens MartijnCuppens force-pushed the master-mc-reboot-update branch from d38e925 to bd960cd Compare July 25, 2019 17:07
@MartijnCuppens MartijnCuppens merged commit ea34b6c into master Jul 25, 2019
@MartijnCuppens MartijnCuppens deleted the master-mc-reboot-update branch July 25, 2019 17:26
@razh razh mentioned this pull request Oct 28, 2019
Closed
@jeromelebleu jeromelebleu mentioned this pull request Nov 22, 2019
Closed
@akrawchyk akrawchyk mentioned this pull request Dec 4, 2019
Closed
@mdo mdo mentioned this pull request Feb 3, 2020
Closed
@WOLFRIEND WOLFRIEND mentioned this pull request Dec 15, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

+2 more reviewers

@coliff coliff coliff left review comments

@ysds ysds ysds approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

css no-backport-to-v4 v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MartijnCuppens @mdo @ysds @coliff