Docs: forms accessibility cleanup#31114
Merged
Merged
Conversation
4207a72 to
8d92e2f
Compare
Member
|
@patrickhlauke this needs a rebase :) |
Member
Author
|
rebased @XhmikosR |
Member
|
@patrickhlauke this needs another rebase. Do note that for v4 these will need to be manually backported so please rethink if they need to be backported and if so make a PR against the v4-dev branch or push to my v4-dev-xmr branch. |
Member
Author
|
ok so after being told to do a rebase, i tried...and have no idea why now all of a sudden i get all those other extraneous commits in here. sigh. |
Member
|
Yeah, that's not a rebase :P A rebase should have only your patches. Anyway, I'll try to fix it tomorrow myself. |
include further advice/information on how to disable faked buttons for keyboard/AT users
seems odd to only mention (separately) label, aria-label etc in input-group and layout. the advice is just as pertinent in other sections like select. checks only skims over this. moving this, in expanded form, into the overview section itself. adding a specific cross-reference (just because they are easily left with no accname at all) in the checks page.
- paradoxically, due to our current problems with validation (see #28414) and the fact that browsers seem to have improved in this area for the most part, it's now actually better to use browser-native validation - added explicit `id` and `aria-describedby` association to at least the server-side form error messages, to show how it should be done properly, and expanded the prose for that explaining this.
Member
Author
|
i think for some reason my local env didn't have the latest main, and was refusing to grab it. had to drop it and refetch it. odd. anyway, i THINK i got it more correctly this time around, let's see... |
d07332c to
b2a8fb4
Compare
Member
Author
|
manual v4 partial backport here #31234 |
- Wordsmithing here and there - Turns some hyphens into em dashes - Turns a long running comma separated list into an unordered list - Rearranges some copy just a bit
Member
|
@patrickhlauke Gave this a read through and made some edits. Let me know if anything looks off, then we can merge. Thanks! |
mdo
approved these changes
Jul 11, 2020
Member
Author
|
yup, all looking good @mdo, thanks. merging. |
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
* Expand on disabled fieldsets and faked buttons include further advice/information on how to disable faked buttons for keyboard/AT users * Centralise accessible name advice in forms overview seems odd to only mention (separately) label, aria-label etc in input-group and layout. the advice is just as pertinent in other sections like select. checks only skims over this. moving this, in expanded form, into the overview section itself. adding a specific cross-reference (just because they are easily left with no accname at all) in the checks page. * Change warning about accessibility, modify server-side example - paradoxically, due to our current problems with validation (see twbs#28414) and the fact that browsers seem to have improved in this area for the most part, it's now actually better to use browser-native validation - added explicit `id` and `aria-describedby` association to at least the server-side form error messages, to show how it should be done properly, and expanded the prose for that explaining this. * Replace `.sr-only` with `.visually-hidden` in new addition * Copy edits for clarity in parenthetical * Copy and formatting tweaks - Wordsmithing here and there - Turns some hyphens into em dashes - Turns a long running comma separated list into an unordered list - Rearranges some copy just a bit Co-authored-by: Mark Otto <markd.otto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<fieldset>aria-describedbythis should at least partially be backported (manually, since v4 doesn't have the overview page)