Skip to content

Fix form file height#30699

Merged
MartijnCuppens merged 3 commits intomasterfrom
master-fod-form-file-validation-feedback
May 5, 2020
Merged

Fix form file height#30699
MartijnCuppens merged 3 commits intomasterfrom
master-fod-form-file-validation-feedback

Conversation

@ffoodd
Copy link
Member

@ffoodd ffoodd commented Apr 30, 2020

Fixes #30438 by using a custom property to set height on .form-file-input and .form-file-label.

Demo: https://deploy-preview-30699--twbs-bootstrap.netlify.app/docs/4.3/forms/validation/#supported-elements

@ffoodd ffoodd requested a review from a team as a code owner April 30, 2020 14:39
@MartijnCuppens
Copy link
Member

Could you add the mb-3 class to the form file here: https://deploy-preview-30699--twbs-bootstrap.netlify.app/docs/4.3/forms/validation/#supported-elements

(and check other places in the docs)

@ffoodd ffoodd force-pushed the master-fod-form-file-validation-feedback branch from 41fbfff to bcf5466 Compare May 4, 2020 14:25
@MartijnCuppens MartijnCuppens changed the title Form file height(s) Fix form file height May 5, 2020
@MartijnCuppens MartijnCuppens merged commit fb0ad7a into master May 5, 2020
@MartijnCuppens MartijnCuppens deleted the master-fod-form-file-validation-feedback branch May 5, 2020 17:43
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom file picker validation message overlaps any following content

2 participants