v5: Unify spacing across components#30564
Conversation
|
The spacer changes LGTM.
Should be in another PR, or at least in a separate commit. Contrast ratio still doesn't meet 4.5 (4.26), but it's an improvement. |
Sounds good, I can re-split this shortly. I recall requests for removing the background and padding entirely on the breadcrumb—that might satisfy the color contrast issue then. Thoughts? |
I'm ok with that. tbh, I regularly need to remove the background and paddings. The background, padding and border radius can be achieved with utilities anyway |
|
The versions dropdown's current item's And for breadcrumbs, I strongly agree with @MartijnCuppens (and will probably try to get off every light gray background as of #30548). Apart from this, I love spacing consistency! |
|
The left padding added by the I also realised there is no Also the the breadcrumb looks so "naked" now: https://deploy-preview-30564--twbs-bootstrap.netlify.com/docs/4.3/components/breadcrumb/ |
|
Maybe we should cover the breadcrumb changes in another PR, @mdo? |
|
Removed breadcrumb restyling, updated the commits, and fixed the docs versions dropdown. Ready for review again! |
MartijnCuppens
left a comment
There was a problem hiding this comment.
LGTM. Wonderful improvement, @mdo!
|
The only thing to question is having both |
Updates alerts, breadcrumbs, cards, dropdowns, list-groups, modals, popovers, and tooltips Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
88c80d7 to
9178a20
Compare
|
@ffoodd, good call, fixed that in the latest rebase |
Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
$spacerof1remRestyles the breadcrumb a smidge to make the background lighter for improved contrast and a little less vertical paddingFixes #25057 for v5.