Skip to content

Bump $dark to $gray-900#30550

Merged
XhmikosR merged 2 commits intomainfrom
master-fod-darker-dark
Sep 29, 2020
Merged

Bump $dark to $gray-900#30550
XhmikosR merged 2 commits intomainfrom
master-fod-darker-dark

Conversation

@ffoodd
Copy link
Member

@ffoodd ffoodd commented Apr 10, 2020

On the road to #30548 , trying to increase contrasts wherever $dark is used.

https://deploy-preview-30550--twbs-bootstrap.netlify.com/docs/5.0/utilities/colors/

FWIW, I really prefer this.

@ffoodd ffoodd requested a review from a team as a code owner April 10, 2020 14:30
@ffoodd ffoodd changed the title feat(colors): bump dark to gray-900 Bump $dark to $gray-900 Apr 10, 2020
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$gray-900 is the same color as the text color, makes sense to switch. WOuld like to have another approval from @mdo for this.

@mdo
Copy link
Member

mdo commented Apr 10, 2020

I believe I made it 800 because then the associated border could be 900, which would allow for some level of slight contrast like our normal borders. This thought was fleshed out more thoroughly in #30342. I could pull those border/bg utils changes from there and push them to a new PR?

@MartijnCuppens
Copy link
Member

I could pull those border/bg utils changes from there and push them to a new PR?

Yup, any reasons not to continue with this then?

@ffoodd
Copy link
Member Author

ffoodd commented May 7, 2020

Friendly ping @mdo :)

@twbs twbs deleted a comment from Lightingtalks May 11, 2020
@mdo
Copy link
Member

mdo commented May 12, 2020

Would the color contrast issues be moot with #30468? I'd like to leave the gray as-is for now as I'm trying to find the right balance of background and border utilities.

@ffoodd
Copy link
Member Author

ffoodd commented May 12, 2020

@mdo Should be good in cases where we generate both background and color—however, it'll be by using black instead of gray (meaning we should fallback to black more frequently).

We may merge (or at least check again) the other one first. It might worth not bumping this gray and prefer to ensure there's no isolated component using gray inappropriately?

@mdo
Copy link
Member

mdo commented May 13, 2020

We may merge (or at least check again) the other one first. It might worth not bumping this gray and prefer to ensure there's no isolated component using gray inappropriately?

👍

@ffoodd ffoodd added the on-hold label May 13, 2020
@ffoodd ffoodd marked this pull request as draft May 20, 2020 08:07
@mdo mdo changed the base branch from master to main June 16, 2020 20:02
@mdo
Copy link
Member

mdo commented Sep 17, 2020

Screw it, let's :shipit: :D.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slating for Alpha 3!

@ffoodd
Copy link
Member Author

ffoodd commented Sep 17, 2020

Great 🎉

@mdo mdo marked this pull request as ready for review September 17, 2020 21:34
@mdo mdo force-pushed the master-fod-darker-dark branch from 7f6bfab to 2a473c7 Compare September 17, 2020 21:35
@XhmikosR XhmikosR removed the on-hold label Sep 29, 2020
@XhmikosR XhmikosR merged commit 7e195a8 into main Sep 29, 2020
@XhmikosR XhmikosR deleted the master-fod-darker-dark branch September 29, 2020 19:09
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@XhmikosR XhmikosR changed the title Bump $dark to $gray-900 Bump $dark to $gray-900 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants