Conversation
MartijnCuppens
left a comment
There was a problem hiding this comment.
$gray-900 is the same color as the text color, makes sense to switch. WOuld like to have another approval from @mdo for this.
|
I believe I made it 800 because then the associated border could be 900, which would allow for some level of slight contrast like our normal borders. This thought was fleshed out more thoroughly in #30342. I could pull those border/bg utils changes from there and push them to a new PR? |
Yup, any reasons not to continue with this then? |
|
Friendly ping @mdo :) |
|
Would the color contrast issues be moot with #30468? I'd like to leave the gray as-is for now as I'm trying to find the right balance of background and border utilities. |
|
@mdo Should be good in cases where we generate both background and color—however, it'll be by using black instead of gray (meaning we should fallback to black more frequently). We may merge (or at least check again) the other one first. It might worth not bumping this gray and prefer to ensure there's no isolated component using gray inappropriately? |
👍 |
|
Screw it, let's |
|
Great 🎉 |
7f6bfab to
2a473c7
Compare
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
On the road to #30548 , trying to increase contrasts wherever
$darkis used.https://deploy-preview-30550--twbs-bootstrap.netlify.com/docs/5.0/utilities/colors/
FWIW, I really prefer this.