Skip to content

Drop support for .form-control-plaintext inside .input-group#28972

Merged
XhmikosR merged 3 commits intomasterfrom
master-ysds-drop-plaintext-with-input-group
Jul 12, 2019
Merged

Drop support for .form-control-plaintext inside .input-group#28972
XhmikosR merged 3 commits intomasterfrom
master-ysds-drop-plaintext-with-input-group

Conversation

@ysds
Copy link
Contributor

@ysds ysds commented Jun 27, 2019

Drop support for .form-control-plaintext inside .input-group, because this cause #28205.

Closes #28205

@ysds ysds requested a review from a team as a code owner June 27, 2019 14:48
@patrickhlauke
Copy link
Member

I'd be cautiously in favor of this.

@XhmikosR XhmikosR merged commit 50f9771 into master Jul 12, 2019
@XhmikosR XhmikosR deleted the master-ysds-drop-plaintext-with-input-group branch July 12, 2019 10:23
patrickhlauke pushed a commit that referenced this pull request Jul 13, 2019
* Revert "Fix readonly-plain-text with button addon (#25871)"

This reverts commit ff40e00.

* Add migration comment
@gcacars
Copy link

gcacars commented Dec 22, 2020

Why? This is so usefull. I lost minutes trying to solve this. Makes no sense if an input field could have append and prepend, but a readonly input not. 🤷‍♂️
We just couldn't use something like below?

.input-group > .form-control-plaintext:not(:first-child) {
  padding-right: 0.75rem;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readonly plain text inside input group

5 participants