Change invalid icon from cross to exclamation mark#28944
Merged
Conversation
patrickhlauke
approved these changes
Jun 22, 2019
Member
|
Any reason why you have width/height set to 10 and not 12? |
The cross icon was confusing since some browsers use it as a reset button.
363aeeb to
a012a4d
Compare
Member
Author
|
The viewport used to be 10 by 10, but this rendered bad in IE. I've now updated it to 12 by 12. |
XhmikosR
approved these changes
Jun 22, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jun 24, 2019
The cross icon was confusing since some browsers use it as a reset button.
XhmikosR
pushed a commit
that referenced
this pull request
Jul 10, 2019
The cross icon was confusing since some browsers use it as a reset button.
Closed
|
This looks A LOT like the fontawesome font-not-found flashing exclamation mark and is definitely a different look and feel from the solid checkmark - so much so that I thought it was an error until I walked back through blame and found this commit. And, since validation icons have been removed from the documentation - I had no way of knowing this as "as intended". I'll lock to the version before this change and hereby put in at least one vote to revert it, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cross icon was confusing since some browsers use it as a reset button.
The svg is handcrafted by myself.
Fixes #28440
Demo: https://deploy-preview-28944--twbs-bootstrap.netlify.com/docs/4.3/components/forms/#server-side