Clean input group flex basis#28785
Merged
Merged
Conversation
MartijnCuppens
approved these changes
May 18, 2019
Member
|
Maybe we should backport this to |
Contributor
Author
|
@MartijnCuppens Yeah, but should check that this work on IE10, but I don't have an IE10 env😞 Would you test in browserstack? |
Member
|
We need to test on IE 11 + Edge (pre Chrome), and ideally temporarily backport this to a v4-dev based branch and test there too with the aforementioned browsers plus IE 10. |
Contributor
Author
|
Testing in IE11 and Edge has been done. But in IE10 on browserstack is difficult, because need a compiled CSS with autoprefixer for IE10 (not the latest browserslist). I'll create a PR from v4-dev brunch for test. (maybe tomorrow) |
XhmikosR
pushed a commit
that referenced
this pull request
May 28, 2019
XhmikosR
pushed a commit
that referenced
this pull request
May 30, 2019
XhmikosR
pushed a commit
that referenced
this pull request
May 30, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28782
width: 1%overwrites the defaultwidth: 100%of.form-controletc.width: 1%can be replaced withflex-basis, becauseflex-basishas priority (ref: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis)%is needed for IE bug https://github.com/philipwalton/flexbugs#flexbug-4I've tested on https://codepen.io/fellows3/pen/Ezpdqj