Skip to content

Calc modal header/footer border radius according to the border width#28775

Merged
MartijnCuppens merged 1 commit into
masterfrom
master-ysds-modal-inner-border-radius
May 28, 2019
Merged

Calc modal header/footer border radius according to the border width#28775
MartijnCuppens merged 1 commit into
masterfrom
master-ysds-modal-inner-border-radius

Conversation

@ysds

@ysds ysds commented May 15, 2019

Copy link
Copy Markdown
Contributor

Fixes #28585

Adjust the border radius of the modal header and footer.

There are other solutions like #28585 (comment), but I chose this way because they already have a border radius.

@ysds ysds requested a review from a team as a code owner May 15, 2019 15:30
@XhmikosR XhmikosR added the v4 label May 27, 2019
@MartijnCuppens MartijnCuppens force-pushed the master-ysds-modal-inner-border-radius branch from 3b12a36 to 5d9436f Compare May 28, 2019 12:14
@MartijnCuppens MartijnCuppens merged commit b283224 into master May 28, 2019
@MartijnCuppens MartijnCuppens deleted the master-ysds-modal-inner-border-radius branch May 28, 2019 12:21
@mdo mdo mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

White gaps in modals because of border radius

4 participants