Remove redundant placeholders in forms docs#28406
Merged
Merged
Conversation
patrickhlauke
requested changes
Mar 5, 2019
Fix context for states Remove redundant commands
Include "Choose..." placeholder for select Fix typo .form-select is not a Bootstrap class
patrickhlauke
requested changes
Mar 5, 2019
patrickhlauke
left a comment
Member
There was a problem hiding this comment.
sorry, last few minor changes. then it looks good to go 👍
mdo
reviewed
Mar 5, 2019
mdo
left a comment
Member
There was a problem hiding this comment.
Please be sure to follow code standards used everywhere in this project—no spaces around attribute's = and double quotes around attribute values. Fixed these here with suggested changes.
Update validated select attributes to follow code standards
Contributor
Author
|
I have updated the validated selects to use |
patrickhlauke
approved these changes
Mar 5, 2019
Member
|
@patrickhlauke: should we backport this to v4? |
Member
yes |
Member
|
OK, I'll cherry pick this to the new v4-dev branch. |
XhmikosR
pushed a commit
that referenced
this pull request
Mar 12, 2019
* Change state field to select * Include "Choose..." placeholder for select * Change validated select to .custom-select
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28260